-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter main route tables #953
Filter main route tables #953
Conversation
Any idea when this PR will get looked at? |
Hey @leighpascoe, sorry for the late reply. We already have a dedicated |
great. thank you. I'll make that change |
@der-eismann I've made the update, and tested it. Ready for re-review |
@svenwltr and @der-eismann Could I please get this re-reviewed. We are looking forward to using the released container instead of building our own forked image |
@svenwltr, Am I missing anything in this PR? |
@der-eismann We have been using aws-nuke on this custom branch for the last 4 months to delete VPC, it's well tested. Could we please get this reviewed and merged? |
use `Filter` instead of custom method
14b4d6e
to
ae6bd3c
Compare
Description
AWS does not allow you to delete main route tables, see AWS docs.
Aws-nuke wants to delete a VPC, it expects the main route table to be deleted first, the main route table cannot be deleted, therefore the VPC fails to delete due to a dependency error.
Proposed Solution
After Describing the route tables, check for any
Associations
whereMain
istrue
. There may be zero to many Associations. If at least onemain
Association is found on the Toute Table, then the Route Table will will not be added to the returned collection of Route TablesI have tested this on VPC with just a main route table, as well as VPC's with multiple route tables.
Related Issues: #946 #785